Put HPX_WITH_APEX in HPXConfig so out of tree projects can test for it #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch, direct actions are now always executed directly on the receiving side. This means that they might get executed in a non-HPX thread.
- hpx::compute::traits::allocator_traits didn't work with std::allocator<T> because it was using the pointer type instead of value_type for the initial value - hpx::compute::vector move operations lead to data being double freed because the move ctor didn't set the rhs data pointer to nullptr
This patch fixes problem in the channel implementation that led to locks being held during suspension.
|
@biddisco Please isolate the APEX fix from all the other branches you merged into this (the direct actions branch, the vector zero copy branch, etc. are all separate PRs). |
|
I'm closing this PR as I have put wrong commits on the branch and I have some new APEX related changes that I'll bundle into a new PR |
|
@biddisco Can we delete this branch as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.