Fixing shutdown when parcels are still in flight #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Oct 7, 2016
|
No, parcelport::operations_in_flight_ is only incremented for outgoing parcels. The flushing is happening before invoking the termination detection action, those can't interfere then. |
|
The effect of this change is that no parcel that is added before the
termination detection is able to get sent after it.
|
hkaiser
requested changes
Oct 8, 2016
- Making sure a receiver connection in the TCP parcelports waits until the connection has been completed to get completely closed - Make sure that no parcels are still in flight when starting the termination detection This completely fixes #2334
hkaiser
approved these changes
Oct 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the connection has been completed to get completely closed
detection
This completely fixes #2334