Adding functionalities to datapar needed by octotiger #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
Nov 12, 2016
hkaiser
commented
- adding datapar serialization
- adding fixed size arrays support from Vc
- enable using datapar_execution on input ranges over vector packs (Vc only for now)
- adding datapar serialization - adding fixed size arrays support from Vc - enable using datapar_execution on input ranges over vector packs (Vc only for now)
hkaiser
force-pushed
the
datapar_octotiger
branch
from
3b8c54d
to
55c27bf
Compare
…st.Simd) - flyby: fix pack serialization
hkaiser
force-pushed
the
datapar_octotiger
branch
from
457a745
to
477f8ef
Compare
- flyby: added datapar_..._shim<> execution policies - added tests
hkaiser
force-pushed
the
datapar_octotiger
branch
3 times, most recently
from
1362e1e
to
b0afa3d
Compare
- properly implement dataseq execution policies
hkaiser
force-pushed
the
datapar_octotiger
branch
from
b0afa3d
to
756f4bb
Compare
sithhell
reviewed
Nov 16, 2016
| @@ -26,17 +27,18 @@ | |||
| namespace hpx { namespace parallel { HPX_INLINE_NAMESPACE(v1) | |||
| { | |||
| /////////////////////////////////////////////////////////////////////////// | |||
| /// Extension: The class datapar_task_execution_policy is an execution | |||
| /// Extension: The class sequential_task_execution_policy is an execution | |||
There was a problem hiding this comment.
why the change from datapar_task_execution_policy? Shouldn't it be dataseq_task_execution_policy?
| /// | ||
| template <typename... Parameters, typename ParametersType = | ||
| typename executor_parameters_join<Parameters...>::type> | ||
| typename rebind_executor< | ||
| datapar_task_execution_policy, executor_type, ParametersType | ||
| sequential_task_execution_policy, executor_type, ParametersType |
There was a problem hiding this comment.
shouldn't that be dataseq_task_execution_policy?
There was a problem hiding this comment.
Thanks, copy&paste error.
| >::type | ||
| with(Parameters &&... params) const | ||
| { | ||
| typedef typename rebind_executor< | ||
| datapar_task_execution_policy, executor_type, ParametersType | ||
| sequential_task_execution_policy, executor_type, ParametersType |
| { | ||
| /// \cond NOINTERNAL | ||
| template <> | ||
| struct is_datapar_execution_policy<dataseq_execution_policy> |
There was a problem hiding this comment.
so dataseq is a datapar execution policy? That sounds confusing.
There was a problem hiding this comment.
is_datapar_execution_policy should probably be renamed to something else, I'm not sure what name to use, though. Any ideas?
|
@sithhell all review comments have been addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.