Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datapar_execution + zip iterator: lambda arguments aren't references #2403

Closed
DavidPfander-UniStuttgart opened this issue Nov 22, 2016 · 4 comments
Closed

datapar_execution + zip iterator: lambda arguments aren't references #2403

DavidPfander-UniStuttgart opened this issue Nov 22, 2016 · 4 comments
Labels
category: algorithms type: defect
Milestone
1.0.0

Comments

@DavidPfander-UniStuttgart
Copy link

Reopened issue in this repository, as I mistakenly started it in the octotiger repository. For the history of the issue see @STEllAR-GROUP/octotiger#22.
@hkaiser hkaiser added this to the 1.0.0 milestone Nov 22, 2016
@hkaiser hkaiser changed the title datapar_execution + zip iterator: lambda arguemnts aren't references datapar_execution + zip iterator: lambda arguments aren't references Nov 22, 2016
hkaiser added a commit that referenced this issue Nov 23, 2016
@hkaiser
Adding test ensuring that #2403 is a non-issue
5a56bab
@hkaiser
Copy link
Member

hkaiser commented Nov 23, 2016

@DavidPfander-UniStuttgart: please verify that things work as expected if the lambda takes a reference (see test added by #2407)

@DavidPfander-UniStuttgart
Copy link
Author

Still not compiling with a reference, see https://gist.github.com/DavidPfander-UniStuttgart/2bde59559f003128c6dcaa1a02cc4501.

BTW the pull request only contains the test, I couldn't find a fix in it.

@hkaiser
Copy link
Member

hkaiser commented Nov 24, 2016 •
edited

The compilation problem is caused by the concept checking. Disabling the concept checking (in particular the parallel::traits::is_indirect_callable<...>::value) makes things compile and run just fine. The solution is related to solving #2402. Specializing is_indirect_callable for the datapar execution policies and zip_iterators should prevent this from happening.

@hkaiser hkaiser mentioned this issue Nov 24, 2016
Merged
hkaiser added a commit that referenced this issue Nov 25, 2016
@hkaiser
Merge pull request #2407 from STEllAR-GROUP/fixing_2403
b6b7467 
Solving #2402 and #2403
@hkaiser
Copy link
Member

hkaiser commented Nov 26, 2016

This has been fixed by merging #2407

@hkaiser hkaiser closed this as completed Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: algorithms type: defect
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@hkaiser @DavidPfander-UniStuttgart