Adding fixes and workarounds to allow compilation with nvcc/msvc (VS2015up3) #2416
Conversation
Alloc for CUDA to be used at the same time as datapar
hkaiser
force-pushed
the
fixing_nvcc_msvc
branch
2 times, most recently
from
c1372c5
to
3f87b2d
Compare
| @@ -1088,15 +1088,15 @@ if(HPX_WITH_CUDA AND NOT HPX_WITH_CUDA_CLANG) | |||
| hpx_library_dir(${CUDA_TOOLKIT_ROOT_DIR}/lib/x64) | |||
| link_directories(${CUDA_TOOLKIT_ROOT_DIR}/lib/x64) | |||
| set(CUDA_NVCC_FLAGS_DEBUG ${CUDA_NVCC_FLAGS_DEBUG};-D_DEBUG;-O0;-g;-G;-Xcompiler=-MDd;-Xcompiler=-Od;-Xcompiler=-Zi;-Xcompiler=-bigobj) | |||
| set(CUDA_NVCC_FLAGS_RELWITHDEBINFO ${CUDA_NVCC_FLAGS_RELWITHDEBINFO};-DNDEBUG;-O2;-g;-Xcompiler=-MD,-O2,-Zi;-Xcompiler=-bigobj) | |||
| set(CUDA_NVCC_FLAGS_RELWITHDEBINFO ${CUDA_NVCC_FLAGS_RELWITHDEBINFO};-DNDEBUG;-O2;-g;--verbose;-Xcompiler=-MD,-O2,-Zi;-Xcompiler=-bigobj;--keep) | |||
There was a problem hiding this comment.
should we keep the verbose and keep flag here?
There was a problem hiding this comment.
I don't see any other way as nvcc is not picking up the flags set through cmake generator settings. I had to comment out this for instance:
hpx/cmake/HPX_AddCompileFlag.cmake
Line 33 in 3f87b2d
There was a problem hiding this comment.
I don't see any other way as nvcc is not picking up the flags set through cmake generator settings. I had to comment out this for instance:
hpx/cmake/HPX_AddCompileFlag.cmake
Line 33 in 3f87b2d
There was a problem hiding this comment.
Hmm, I don't like having that as a default. Sounds like there's a bigger underlying issue here. Could we open a ticket and fix it properly instead?
There was a problem hiding this comment.
Sure. You have 'solved' the very same issue by unconditionally setting the compilation flags for all build configurations (here:
hpx/cmake/HPX_AddCompileFlag.cmake
Line 34 in 3f87b2d
| set(CUDA_NVCC_FLAGS_MINSIZEREL ${CUDA_NVCC_FLAGS_MINSIZEREL};-DNDEBUG;-O1;-Xcompiler=-MD,-O1;-Xcompiler=-bigobj) | ||
| set(CUDA_NVCC_FLAGS_RELEASE ${CUDA_NVCC_FLAGS_RELEASE};-DNDEBUG;-O2;-Xcompiler=-MD,-Ox;-Xcompiler=-bigobj) | ||
| endif() | ||
| set(CUDA_SEPARABLE_COMPILATION ON) | ||
| set(CUDA_NVCC_FLAGS ${CUDA_NVCC_FLAGS};-gencode=arch=compute_30,code=sm_30) | ||
| set(CUDA_NVCC_FLAGS ${CUDA_NVCC_FLAGS};-gencode=arch=compute_35,code=sm_35) | ||
| # set(CUDA_NVCC_FLAGS ${CUDA_NVCC_FLAGS};-gencode=arch=compute_35,code=sm_35) |
There was a problem hiding this comment.
Sorry, that's a left-over from experimentation
| { | ||
| return channel_.get(launch::sync); | ||
| } | ||
| result_type get_value(error_code& ec) | ||
| { | ||
| return channel_.get(launch::sync); |
There was a problem hiding this comment.
Did you miss to pass the error code here?
|
We should have really reverted the nvcc flags and look for a proper fix.
Not everyone wants to keep the intermediates and have verbose output.
|
|
I will remove |
This also fixes some possible problems with base_lco_with_value