Adapt execution policy name changes from C++17 #2436
Conversation
- those are now in namespace hpx::parallel::execution (per C++17) - added compatibility option to define aliases representing old names
… for unary transform_reduce
| @@ -24,18 +24,18 @@ | |||
| #include <type_traits> | |||
| #include <utility> | |||
|
|
|||
| namespace hpx { namespace parallel { HPX_INLINE_NAMESPACE(v1) | |||
| namespace hpx { namespace parallel { namespace execution | |||
There was a problem hiding this comment.
why is this one not versioned anymore?
There was a problem hiding this comment.
It is versioned. In full correspondence with the proposal: hpx::parallel::execution::concurrency_v2 (there it is std::execution::concurrency_v2).
There was a problem hiding this comment.
Ok. I clearly miss where the versioning is done here. I miss the inline namespace v2 or something similar.
There was a problem hiding this comment.
Right, my misunderstanding - I mixed that up with the executor work I'm doing right now. Please disregard my first comment.
I assume, you are talking about moving (keeping) the datapar execution policies into a versioned namespace. I agree, that should probably be done.
| # HPX_WITH_EXECUTION_POLICY_COMPATIBILITY: introduced in V1.0.0 | ||
| hpx_option(HPX_WITH_EXECUTION_POLICY_COMPATIBILITY BOOL | ||
| "Enable old execution policy names in API (default: OFF)" | ||
| OFF ADVANCED) |
There was a problem hiding this comment.
Can we have this on by default?
| @@ -78,6 +79,7 @@ The options are split into these categories: | |||
| [[[#build_system.cmake_variables.HPX_WITH_DATAPAR_BOOST_SIMD] `HPX_WITH_DATAPAR_BOOST_SIMD:BOOL`][Enable data parallel algorithm support using the external Boost.SIMD library (default: OFF)]] | |||
| [[[#build_system.cmake_variables.HPX_WITH_DATAPAR_LIBFLATARRAY] `HPX_WITH_DATAPAR_LIBFLATARRAY:BOOL`][Enable data parallel algorithm support using the external LibFlatArray (default: OFF)]] | |||
| [[[#build_system.cmake_variables.HPX_WITH_DATAPAR_VC] `HPX_WITH_DATAPAR_VC:BOOL`][Enable data parallel algorithm support using the external Vc library (default: OFF)]] | |||
| [[[#build_system.cmake_variables.HPX_WITH_EXECUTION_POLICY_COMPATIBILITY] `HPX_WITH_EXECUTION_POLICY_COMPATIBILITY:BOOL`][Enable old execution policy names in API (default: OFF)]] | |||
There was a problem hiding this comment.
the new default should be reflected here
There was a problem hiding this comment.
BTW, I think we should remove this file from the repository altogether as it is regenerated by cmake.
|
Can I go ahead and merge this now? |
|
The comments left by @sithhell have been addressed. |
This fixes #2390