Ensure that using %osthread% during logging will not throw for non-hpx threads #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sithhell
reviewed
Feb 2, 2017
src/runtime.cpp
Outdated
| @@ -1208,6 +1208,20 @@ namespace hpx | |||
| return rt->get_thread_manager().get_worker_thread_num(); | |||
There was a problem hiding this comment.
can't we call get_worker_thread_num(hpx::throws); to avoid code duplication?
There was a problem hiding this comment.
Sure, good point. My rationale for the new function was to leave the API unchanged.
hkaiser
force-pushed
the
fixing_logging
branch
from
c9852fe
to
5f2f1f3
Compare
|
@sithhell Your comment has been addressed |
sithhell
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.