Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making sure the sine performance counter module gets loaded only for … #2478

Merged
merged 1 commit into from Feb 4, 2017
Merged

Making sure the sine performance counter module gets loaded only for … #2478

merged 1 commit into from Feb 4, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Feb 2, 2017

…the corresponding example

  • this avoids spurious exceptions at startup

@hkaiser hkaiser added this to the 1.0.0 milestone Feb 2, 2017
@hkaiser hkaiser mentioned this pull request Feb 2, 2017
Closed
@hkaiser
Making sure the sine performance counter module gets loaded only for …
bfdf77c 
…the corresponding example

- this avoids spurious exceptions at startup
sithhell
sithhell approved these changes Feb 2, 2017
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit 3bf35c4 into master Feb 4, 2017
@hkaiser hkaiser deleted the fixing_2477 branch February 4, 2017 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
category: examples category: performance counters type: compatibility issue
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell