Extending command line option --hpx:print-counter-destination to support value 'none' #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
Feb 5, 2017
hkaiser
commented
- this suppresses any generated output (useful when using with ITT or APEX)
…ort value 'none' - this suppresses any generated output (useful when using with ITT or APEX)
sithhell
reviewed
Feb 6, 2017
| #if HPX_HAVE_ITTNOTIFY != 0 && !defined(HPX_HAVE_APEX) | ||
| // don't generate any console-output if the ITTNotify API is used | ||
| if (!no_output && destination_is_cout && use_ittnotify_api) | ||
| no_output = true; |
There was a problem hiding this comment.
is this really what we want? What about if we want to plot performance counters when not running under vtune?
There was a problem hiding this comment.
In this case the use_itt_notify will be false, I guess.
There was a problem hiding this comment.
Ahh, makes sense, I wasn't aware of that.
sithhell
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.