wait_or_add_new returning thread_id_type #2495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sithhell
force-pushed
the
wait_or_add_new_improvement
branch
from
ff6c61f
to
f082a42
Compare
hkaiser
reviewed
Feb 15, 2017
|
|
||
| if (scheduler.SchedulingPolicy::wait_or_add_new( | ||
| num_thread, running, idle_loop_count)) | ||
| bool running = this_state.load() < state_stopping; |
There was a problem hiding this comment.
Once merged, this would be duplicated (see https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/runtime/threads/detail/scheduling_loop.hpp#L343).
sithhell
force-pushed
the
wait_or_add_new_improvement
branch
from
f082a42
to
beb649e
Compare
Instead of pushing the newly available work to the pending queues, wait_or_add_new now returns a newly created thread_data pointer to be used in the scheduling loop.
sithhell
force-pushed
the
wait_or_add_new_improvement
branch
from
beb649e
to
fda7093
Compare
|
@sithhell This needs some fixes before it can be merged. Should it still go into the V1.0 release? |
|
Closing as it doesn't show any benefit, makes perfomance worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pushing the newly available work to the pending queues,
wait_or_add_new now returns a newly created thread_data pointer to
be used in the scheduling loop.