Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of unlocking, ignore the lock while creating the message handler #2522

Merged
merged 2 commits into from Mar 1, 2017
Merged

Instead of unlocking, ignore the lock while creating the message handler #2522

merged 2 commits into from Mar 1, 2017

Conversation

sithhell
Copy link
Member

This fixes #2517

@sithhell sithhell added this to the 1.0.0 milestone Feb 26, 2017
@hkaiser
Copy link
Member

hkaiser commented Feb 26, 2017

@sithhell I added another commit which I had lying around. I hope you don't mind.

hkaiser
hkaiser approved these changes Feb 26, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sithhell
Copy link
Member Author

@hkaiser perfect!

@hkaiser hkaiser merged commit 56d5c0e into master Mar 1, 2017
@hkaiser hkaiser deleted the fixing_2517 branch March 1, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
type: race condition
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Race condition during Parcel Coalescing Handler creation
2 participants
@sithhell @hkaiser