Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an inline versioning namespace before 1.0 release #2566

Closed
brycelelbach opened this issue Mar 25, 2017 · 2 comments
Closed

Add an inline versioning namespace before 1.0 release #2566

brycelelbach opened this issue Mar 25, 2017 · 2 comments

Comments

@brycelelbach
Copy link
Member

We don't have an inline versioning namespace like all the cool kids (libc++, Vc, Ranges V3, etc):

#define HPX_BEGIN_NAMESPACE namespace hpx { inline namespace HPX_VERSION_NAMESPACE {
#define HPX_END_NAMESPACE }}

I'd like to do this before v1. I'll assign myself.

@hkaiser
Copy link
Member

hkaiser commented Mar 25, 2017

@brycelelbach please note that we have a compatibility macro for the inline part of the namespaces to allow older compiler to do the right thing. We use that for the parallel algorithms and such:

#include <hpx/parallel/config/inline_namespace.hpp> // this is where the macro is defined
namespace hpx { HPX_INLINE_NAMESPACE(v1)
{
    ...
}}

Also, the inline namespace needs to be pre-declared in the header file for the older compilers.

@hkaiser hkaiser modified the milestones: 1.0.0, 1.1.0 Apr 23, 2017
@hkaiser
Copy link
Member

hkaiser commented Oct 12, 2017

I'll go ahead and close this as the release is out for quite some time now.

@hkaiser hkaiser closed this as completed Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants