Update CMake minimum required version to 3.0.2 (closes #2621) #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to change the docs as well (https://github.com/STEllAR-GROUP/hpx/blob/master/docs/manual/build_system/prerequisites.qbk#L63 and https://github.com/STEllAR-GROUP/hpx/blob/master/docs/manual/build_system/prerequisites.qbk#L92). |
|
Updated the documentation. |
hkaiser
reviewed
May 11, 2017
CMakeLists.txt
Outdated
| # We require at least CMake V2.8.12 | ||
| cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR) | ||
| # We require at least CMake V3.0.2 | ||
| cmake_minimum_required(VERSION 3.0.2 FATAL_ERROR) | ||
|
|
||
| # explicitly set certain policies | ||
| cmake_policy(VERSION 2.8.12) |
There was a problem hiding this comment.
Shouldn't this be changed to 3.0.2 as well?
There was a problem hiding this comment.
I'm not saying this has to be changed. I'm asking whether this is necessary... To answer this you'd need to understand what the cmake_policy(<version>) macro actually does.
|
From what I could read from the docs, using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2621