This patch makes sure that all parcels in a batch are properly handled #2652
Conversation
- the split_gids container is not a zombie anymore for anything but the first parcel
| continue; | ||
|
|
||
| // collect the necessary size the serialization operation | ||
| hpx::serialization::detail::preprocess preprocess; |
There was a problem hiding this comment.
This will not work. preprocess needs to be kept alive as part of parcel_await. Once we have a future we need to wait on, the completion handlers are registered to exactly this object, once we leave the scope in line 63, we will get segfaults due to dangling pointers, for example here:
https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/runtime/serialization/detail/preprocess.hpp#L71
That's also the reason, why we need to keep this alive.
There was a problem hiding this comment.
| archive_.reset(); | ||
| archive_ << parcels_[idx_]; | ||
| // send every parcel only once | ||
| if (handled_[idx_]) |
There was a problem hiding this comment.
I think that's wrong. parcels need to get preprocessed as many times as there are no futures to be waited on. For example, a shared_futurehpx::id_type inside a parcels might need to be proprocessed three times. First, the future is not ready and needs to be waited on, second (now the future is ready) the id_type needs to be split (another future needs to be waited on), the third one is the last in the fixed point iteration to ensure everything is ready and the last round did indeed create a value and not an exception, that is, to calculate the final size of the data to be sent.
There was a problem hiding this comment.
I removed this commit, you were right.
hkaiser
force-pushed
the
fixing_parcel_await
branch
from
d490a92
to
4218539
Compare
|
Closing this as the problem has been addressed by #2619 |
@sithhell please verify