Drop support for VS2013 #2653
Merged
Drop support for VS2013 #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naios
reviewed
May 25, 2017
| @@ -918,8 +918,8 @@ if(CMAKE_COMPILER_IS_GNUCXX AND HPX_WITH_GCC_VERSION_CHECK) | |||
| endif() | |||
|
|
|||
| if(MSVC) | |||
| if(NOT (MSVC11 OR MSVC12 OR MSVC14)) | |||
| hpx_error("MSVC x64 2012 or higher is required.") | |||
| if(NOT (MSVC14)) | |||
There was a problem hiding this comment.
Looks good, however it's inconvenient to have a CMake variable for each MSVC version, a better approach would be the usage of the MSVC_VERSION variable: if(NOT (MSVC_VERSION LESS 1900))
There was a problem hiding this comment.
That's out of the scope of this PR, but feel free to propose those changes.
There was a problem hiding this comment.
Yes it's definitly out of scope, I just wanted to note it so we can pick it up in the future...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.