Add an is_tuple_like trait for sequenceable type detection #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Jun 7, 2017
hpx/traits/is_tuple_like.hpp
Outdated
| util::tuple_size<T>::value | ||
| )>::type> : std::true_type { }; | ||
| }} | ||
|
|
There was a problem hiding this comment.
Please try to adapt your style of formatting to the rest of HPX. I'll send you a .clang-format file which you can use as a starting point.
|
Please add the new #include here: https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/include/traits.hpp |
|
I fixed the code formatting and added the trait to the include compilation. |
|
@Naios: the current build failures are caused by a bogus commit you picked up by merging from master. Please merge again, this should resolve the issue. |
|
@hkaiser I rebased the PR accordingly, but the CI is still failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2685, otherwise the unit test won't pass