Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refining C++ language mode detection for MSVC #2694

Merged
merged 1 commit into from Jun 17, 2017
Merged

Refining C++ language mode detection for MSVC #2694

merged 1 commit into from Jun 17, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jun 12, 2017 •
edited

  • adding feature test for C++17 template variables

@hkaiser
Refining C++ language mode detection for MSVC
f218738 
- adding feature test for C++17 variable templates
@hkaiser hkaiser added this to the 1.1.0 milestone Jun 12, 2017
sithhell
sithhell approved these changes Jun 16, 2017
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkaiser hkaiser merged commit 30b37b9 into master Jun 17, 2017
@hkaiser hkaiser deleted the detect_cpp_mode branch June 17, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
category: CMake category: core compiler: msvc type: compatibility issue
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell