Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial import of icu string serializer #2715

Closed
wants to merge 1 commit into from

Conversation

ct-clmsn
Copy link
Contributor

serialization functions to support direct icu::UnicodeString interactions.

@hkaiser
Copy link
Member

hkaiser commented Jun 25, 2017

Chris, thanks for contributing this code. I'm not sure however if we should add it to HPX as we don't have any dependencies to ICU in any way. This looks like more of something you'd want to keep local to your application.

But I'm open to discussing this. What do others think?

@ct-clmsn
Copy link
Contributor Author

ct-clmsn commented Jun 25, 2017

Understood; figured if icu was a boost::regex dependency, it might not be a particularly big deal but, I can understand the concern about additional dependencies.

@hkaiser
Copy link
Member

hkaiser commented Jun 25, 2017

Understood; figured if icu was a boost::regex dependency, it might not be a particularly big deal but, I can understand the concern about additional dependencies.

Yah, it's an optional Boost.Regex dependency. We could add it as an optional dependency (make it available if Boost.Regex has it enabled), but we're planning to move to std.regex at some point which would make this unnessecary.

@ct-clmsn ct-clmsn closed this Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants