Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the appveyor build to use the minimal required MSVC version #2844

Closed
Naios opened this issue Aug 18, 2017 · 2 comments
Closed

Change the appveyor build to use the minimal required MSVC version #2844

Naios opened this issue Aug 18, 2017 · 2 comments

Comments

@Naios
Copy link
Contributor

Naios commented Aug 18, 2017

The Visual Studio version used by the Appveyor CI should reflect the minimal required MSVC version
2015 instead of the latest one.
This could help to prevent issues where the code was developed in a later MSVC version but fails to build on the minimal required one.

@hkaiser
Copy link
Member

hkaiser commented Aug 18, 2017

@Naios: this can be easily done by changing this line: https://github.com/STEllAR-GROUP/hpx/blob/master/appveyor.yml#L9 to read Visual Studio 2015. We could even have both versions in there (see: https://www.appveyor.com/docs/build-environment/#using-multiple-images-for-the-same-build).

@Naios
Copy link
Contributor Author

Naios commented Aug 18, 2017

@hkaiser Thanks for the quick reply, I'll try that out.

Naios added a commit to Naios/hpx that referenced this issue Aug 18, 2017
Naios added a commit to Naios/hpx that referenced this issue Aug 18, 2017
Naios added a commit to Naios/hpx that referenced this issue Aug 19, 2017
Naios added a commit to Naios/hpx that referenced this issue Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants