Allowing for non-default-constructible component types #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkaiser |
sithhell
reviewed
Aug 22, 2017
| naming::gid_type create(std::size_t count, std::false_type) | ||
| { | ||
| // shouldn't ever be called for non-default-constructible types | ||
| HPX_ASSERT(false); |
There was a problem hiding this comment.
Why do we have to resort to a runtime error here?
There was a problem hiding this comment.
What do you suggest? A static assert would trigger for any non-default constructible type.
There was a problem hiding this comment.
Only if we call new_ without arguments, no?
There was a problem hiding this comment.
No, always - this function is called by create(size_t) which is a virtual function.
| naming::gid_type create(std::size_t count, std::false_type) | ||
| { | ||
| // shouldn't ever be called for non-default-constructible types | ||
| HPX_ASSERT(false); |
sithhell
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krivenko: please verify this solves the problem you reported the other day,