Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use sched_getcpu on linux machines #2865

Merged
merged 1 commit into from Aug 30, 2017
Merged

Only use sched_getcpu on linux machines #2865

merged 1 commit into from Aug 30, 2017

Conversation

biddisco
Copy link
Contributor

@biddisco biddisco commented Aug 28, 2017

This Fixes #2862

#if defined(__linux) || defined(__linux__)
# include <sched.h>
#else
# define sched_getcpu() '#'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that break on non-Linux machines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking closer: all is fine. Thanks!

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@biddisco
Copy link
Contributor Author

Some Appveyor thingy seems to have failed. Do I merge anyway?

@biddisco biddisco merged commit 1a50ac6 into master Aug 30, 2017
@sithhell sithhell deleted the fixing_2862 branch August 30, 2017 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants