Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions should only be logged if unhandled #289

Closed
brycelelbach opened this issue Jul 10, 2012 · 4 comments
Closed

Exceptions should only be logged if unhandled #289

brycelelbach opened this issue Jul 10, 2012 · 4 comments
Milestone

Comments

@brycelelbach
Copy link
Member

[reported by blelbach] [Trac time Tue Jan 10 19:19:10 2012] I get this exception, logged to a file, when I use any application other than the sine application with the sine component built. The exception is not propagated to the program.

[13:16:59]:wash@pyxis:/home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release$ cat hpx.7136.log 
(T00000001/000000000126e000.01/----------------) P00000001/----------------.-- 13:16.59.300 [0000000000000001]  <always> [ERR] rethrow_exception: throwing exception: 
[stack_trace]: 14 frames:
0x7fb2b50ccbc4  : hpx::detail::backtrace() + 0x74 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b50dfc07  : void hpx::detail::throw_exception<hpx::exception>(hpx::exception const&, std::string const&, std::string const&, int) + 0x77 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2a8c94dc3  : ??? + 0xa8c94dc3 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx_component_sine.so
0x7fb2a8c940df  : ??? + 0xa8c940df in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx_component_sine.so
0x7fb2b5165272  : hpx::components::server::runtime_support::load_startup_shutdown_functions(boost::plugin::dll&) + 0x4d2 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b51665a2  : hpx::components::server::runtime_support::load_component(hpx::util::section&, std::string const&, std::string const&, boost::filesystem3::path, hpx::naming::gid_type const&, hpx::agas::addressing_service&, bool, bool, boost::program_options::options_description&) + 0xb42 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b5167c94  : hpx::components::server::runtime_support::load_components(hpx::util::section&, hpx::naming::gid_type const&, hpx::agas::addressing_service&) + 0x544 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b50b5cf8  : ??? + 0xb50b5cf8 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b50901fd  : ??? + 0xb50901fd in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b509384d  : ??? + 0xb509384d in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b50f1511  : hpx::runtime_impl<hpx::threads::policies::local_priority_queue_scheduler, hpx::threads::policies::callback_notifier>::run_helper(boost::function<int ()>, int&) + 0xd1 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b50e8c48  : ??? + 0xb50e8c48 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b5218dc6  : ??? + 0xb5218dc6 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
0x7fb2b52190a9  : ??? + 0xb52190a9 in /home/wash/development/parallex/trunk/hpx/gcc-4.6.2-release/install/lib/hpx/libhpx.so.0
[what]: The Sine component is not enabled on the commandline (--sine), bailing out.: HPX(not_implemented)
[locality]: 1
[hostname]: 127.0.0.1:7910
[pid]: 7136
[function]: sine::startup
[file]: /home/wash/development/parallex/trunk/hpx/examples/performance_counters/sine/sine.cpp
[line]: 167
[os-thread]: 0
[thread_id]: 000000000126e000
[thread_name]: pre_main
[version]: V0.8.0-trunk (AGAS: V2.1), SVN: 6696M
[boost]: V1.47.0
[build-type]: release
[date]: Jan 10 2012 12:21:24
[platform]: linux
[compiler]: GNU C++ version 4.6.2
[stdlib]: GNU libstdc++ version 20111103
@brycelelbach
Copy link
Member Author

[comment by hkaiser] [Trac time Tue Jan 10 19:48:30 2012] That's what's expected.

@brycelelbach
Copy link
Member Author

[comment by blelbach] [Trac time Tue Jan 10 19:56:07 2012] Huh?

How is an exception expected behavior? Are you telling me that the generation of a log file and error is intentional?

@brycelelbach
Copy link
Member Author

[comment by blelbach] [Trac time Tue Jan 10 20:01:41 2012] I think it is poor design to force all applications to generate a logfile every run with the default logging parameters just because the sine performance counter wasn't loaded. Even component module loading warnings don't cause this. Can you please fix this to not generate a log message at the level?

@brycelelbach
Copy link
Member Author

[comment by hkaiser] [Trac time Wed Jan 11 02:52:55 2012] Fixed in rev. [6700]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant