Adding test to trigger problem reported in #2916 #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
Sep 30, 2017
hkaiser
commented
- flyby: channel::close() now returns the number of elements left in the channel
hkaiser
force-pushed
the
fixing_2916
branch
2 times, most recently
from
6cfd983
to
029fa1a
Compare
|
This branch somehow got the debugging commit on this branch that was changed to use the HAVE_UNISTD_H check instead. You should just remove that commit and rebase onto the later master. |
|
Will do, @sithhell added this here for some reason. |
sithhell
requested changes
Oct 10, 2017
| }); | ||
|
|
||
| // Free resources | ||
| result.then([&free_resources, target, &count](hpx::shared_future<int>) |
There was a problem hiding this comment.
This will still fail as free_resources is captured by reference.
- flyby: channel::close() now returns the number of elements left in the channel
|
@sithhell your comments have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.