Default pool rename #2926
Merged
Default pool rename #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Oct 2, 2017
| @@ -361,7 +361,7 @@ namespace hpx { namespace resource { namespace detail | |||
| // exclusively if dynamic pools are enabled. | |||
| // Also, by default, the first PU is always exclusive | |||
| // (to avoid deadlocks). | |||
| add_resource(p, "default", | |||
| add_resource(p, initial_thread_pools_[0].pool_name_, | |||
There was a problem hiding this comment.
May I suggest you use the get_default_pool_name() member function everywhere here instead of the initial_thread_pools_[0].pool_name_ you currently use?
There was a problem hiding this comment.
inside detail::partitioner I used initial_thread_pools_[0].pool_name, but outside it, I used get_default_pool_name. Not a big deal. I will change it.
Users might want to create numa-pool-0, numa-pool-1 etc and rename the default pool to one of them to make it easier to loop over pools in code and not treat pool 0 specially.
biddisco
force-pushed
the
default_pool_rename
branch
from
91fbdb9
to
aed39b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #2925