Classify chunk_size_iterator to input iterator tag. (Fix #2866) #2932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2866 .
Now, I classify
chunk_size_iterator
to input_iterator_tag, not forward_iterator_tag.What I worry is that if
chunk_size_iterator
will be used incorrectly in any place, he/she may not know what is incorrect and wander with mistery bug.hpx/hpx/parallel/executors/execution_fwd.hpp
Lines 193 to 201 in 954818a
For example, in above code, there is a nothing which explicitly notices that
chunk_size_iterator
is input iterator.So, an user who utilizes
chunk_size_iterator
"indirectly" can make a mistake which violates multi-pass gaurantee.