Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make sure the function vtables are initialized before use" #2951

Merged
merged 1 commit into from Oct 16, 2017
Merged

Revert "Make sure the function vtables are initialized before use" #2951

merged 1 commit into from Oct 16, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Oct 16, 2017

Reverts #2945

The original patch has caused issues during de-serialization of functions.

@hkaiser hkaiser added this to the 1.1.0 milestone Oct 16, 2017
sithhell
sithhell approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll this back ASAP and find a different fix to solve the static order initialization fiasco.

@hkaiser hkaiser merged commit 610f9d4 into master Oct 16, 2017
@hkaiser hkaiser deleted the revert-2945-enforce_function_initialization branch October 16, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell