Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OS-Thread throttling #2955

Closed
sithhell opened this issue Oct 16, 2017 · 3 comments
Closed

Fix OS-Thread throttling #2955

sithhell opened this issue Oct 16, 2017 · 3 comments
Labels
category: resource_partitioner type: feature request
Milestone
1.1.0

Comments

@sithhell
Copy link
Member

The current behavior of attempting to shut down an entire OS thread when dynamically removing a PU from a thread pool seems to be not a good idea.

We should rather add a condition variable which checks if the OS thread is enabled or not and waits for the proper condition. This will be a clean solution and will not meddle with the shutdown procedure.
@sithhell sithhell added this to the 1.1.0 milestone Oct 16, 2017
@hkaiser
Copy link
Member

hkaiser commented Oct 16, 2017

We already have this condition-variable: https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/runtime/threads/policies/scheduler_base.hpp#L360

sithhell pushed a commit that referenced this issue Oct 17, 2017
Partially reverting #2891
13c3f67 
 - Partially reverting changes to wait_or_add_new and the termination detection
 - Commenting out throttle test, to be fixed within #2955
@sithhell sithhell mentioned this issue Oct 17, 2017
Merged
@msimberg msimberg mentioned this issue Nov 7, 2017
Closed
2 tasks
@hkaiser
Copy link
Member

hkaiser commented Dec 31, 2017

@sithhell can this be closed now?

@msimberg
Copy link
Contributor

I think this can be closed now. @sithhell please reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: resource_partitioner type: feature request
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@msimberg @sithhell @hkaiser