Fixing wrapper_heap alignment problems #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures that the addresses returned from the wrapper_heap are correctly aligned for the underlying objects.
Conflicts: hpx/runtime/components/server/wrapper_heap_list.hpp
|
This PR should be ready now. |
biddisco
approved these changes
Nov 30, 2017
| first_free_ = pool_; | ||
| size_ = s / element_size_; //-V104 | ||
| free_size_ = size_; | ||
| first_free_ = (reinterpret_cast<std::size_t>(pool_) |
There was a problem hiding this comment.
uintptr_t maybe for the first_free usage throughout?
There was a problem hiding this comment.
std::size_t is good enough as it is guaranteed to be able to hold pointers.
|
@hkaiser do you still want to test this on windows? Appveyor is fine with it. I'd really like to move on here, the bug that's fixed here is really severe. |
|
@sithhell I'd appreciate it if I had a bit more time to test this on windows. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that the addresses returned from the wrapper_heap are
correctly aligned for the underlying objects.