Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI inspect checks before building #3029

Closed
wants to merge 1 commit into from
Closed

Run CI inspect checks before building #3029

wants to merge 1 commit into from

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Nov 26, 2017

No description provided.

@hkaiser hkaiser added this to the 1.1.0 milestone Nov 26, 2017
hkaiser
hkaiser approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Nov 26, 2017

CircleCI is still failing, not sure why...

@K-ballo
Copy link
Member Author

K-ballo commented Nov 26, 2017

master is in a bad state:

/hpx\parallel\executors\execution.hpp: *Endline Whitespace*: 184
/hpx\parallel\executors\execution_fwd.hpp: *Line length limit*: 380

...and the new location of inspect within the CI script must be causing its artifacts to be ignored. I'll look into it.

@K-ballo K-ballo force-pushed the inspect-first branch 10 times, most recently from 4347cf2 to a7e1fc2 Compare November 26, 2017 22:50
@K-ballo
Copy link
Member Author

K-ballo commented Nov 26, 2017

It seems circle-ci won't even look at generated artifacts when the build fails :/

@K-ballo
Copy link
Member Author

K-ballo commented Dec 1, 2017

Abandoning, as circle-ci won't collect artifacts for a failed build.

@K-ballo K-ballo closed this Dec 1, 2017
@hkaiser
Copy link
Member

hkaiser commented Dec 1, 2017

This may be a thing again after we've moved to CircleCI V2.

@sithhell
Copy link
Member

sithhell commented Dec 1, 2017

It's already implemented there. See #3036.

@K-ballo K-ballo deleted the inspect-first branch December 2, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: buildbot type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K-ballo @hkaiser @sithhell