Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #3044 #3047

Merged
merged 1 commit into from Dec 5, 2017
Merged

Fixing #3044 #3047

merged 1 commit into from Dec 5, 2017

Conversation

sithhell
Copy link
Member

@sithhell sithhell commented Dec 4, 2017

  • Fixing local function invocations:
    • Only invoke functions locally (sync or asyn) if the calling context is the same as requested and if the action has not been decorated.
    • Fixes tests:

@hkaiser hkaiser added this to the 1.1.0 milestone Dec 4, 2017
Fixing local function invocations
fdb97a9 
Only invoke functions locally (sync or asyn) if the calling context is the same
as requested and if the action has not been decorated.
hkaiser
hkaiser approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sithhell sithhell merged commit f16b360 into master Dec 5, 2017
@sithhell sithhell deleted the fix_tests branch December 5, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: actions type: defect
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sithhell @hkaiser