Fixing a race with timed suspension (second attempt) #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Feb 9, 2018
| thread_priority priority = thread_priority_normal, | ||
| error_code& ec = throws) | ||
| { | ||
| std::atomic<bool> timer_started(false); |
There was a problem hiding this comment.
Won't this atomic go out of scope before the timer thread can access it?
sithhell
force-pushed
the
fix_timed_suspension
branch
2 times, most recently
from
c0e5371
to
e3ec5b7
Compare
|
The inspect failure is not related to this PR. Pycicle tests run through and I verified that everything works locally. This PR is now potentially ready to be merged. |
At least one of the inspect failures seems to be related to your changes (using atomic). Would you mind fixing the other one while you're at it as well? |
When doing a timed suspension on a thread, there were several race conditions between setting the different participating thread states, which should now be fixed. The problem was observable with the wait_for_1751 regression test.
sithhell
force-pushed
the
fix_timed_suspension
branch
from
e3ec5b7
to
692c675
Compare
|
Right. missed the missing atomic header. The other inspect error is already fixed on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a timed suspension on a thread, there were several race conditions
between setting the different participating thread states, which should now be
fixed. The problem was observable with the wait_for_1751 regression test.
This is the second attempt (after #3153), fixing the previous issues.