adding the missing unset() function to cpu_mask() for case of more than 64 threads #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
changed the title
hkaiser
reviewed
Feb 13, 2018
hpx/runtime/threads/cpu_mask.hpp
Outdated
| inline void unset(mask_type& mask, std::size_t idx) | ||
| { | ||
| mask.set(idx,0); | ||
| } |
There was a problem hiding this comment.
Please follow the formatting of the surrounding code. Alternatively use clang-format (with the .clang-format file in the root of this project) to format the code sections you touched.
|
inspect is not happy with this: https://9537-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.nf3VXrZ/hpx_inspect_report.html As mentioned before - clang-format can help with these issues... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.