Addition of new arithmetic performance counter "Count" #3206
Conversation
victor-ludorum
changed the title
| @@ -986,6 +986,14 @@ namespace hpx { namespace performance_counters | |||
| > counter_t; | |||
| gid = components::server::construct<counter_t>( | |||
| complemented_info, base_counter_names); | |||
| } | |||
| else if (p.countername_ == "count") { | |||
There was a problem hiding this comment.
The indentation seems to be off here.
| { "/arithmetics/count", performance_counters::counter_aggregating, | ||
| "returns the count value of all values of the specified " | ||
| "base counters; pass the required base counters as the parameters: " | ||
| "/arithmetics/count@<base_counter_name1>,<base_counter_name2>", |
There was a problem hiding this comment.
If the counter returns the number of values in the accumulator, wouldn't it always return the number of base-counters specified as its argument?
There was a problem hiding this comment.
@hkaiser Thanks for the review 😊 . Actually , Yes it will return the number of base-counters . Sorry for being little unclear . As mean, median and variance are done on the base counter values . Similarly count is also there to return the count of values .
|
@victor-ludorum while I understand that this is a small project for you to better understand how performance counters work (and kudos to you that you got it in place!), I'm not sure if adding this counter to the HPX core would be useful. What would be a possible use case for it? |
|
@hkaiser Thanks !! Actually , I have planned to work on this as my GSOC project . Therefore, I want to check that whether the steps which I have thought to implement any new counter is correct or not . Therefore , I have created this PR so that you or any experienced one should suggest the steps is accurate or not .
Please suggest , how can I improve my work . On which part I may work that should be good and more informative . I will soon make a proposal so that you can suggest what should be done in this project to make it worth for GSOC project . |
|
@hkaiser Hello sir 😊 !! Do I close this PR . Before closing I just want one advice that whether this process is appropriate to add any new arithmetic performance counter to HPX . |
|
@victor-ludorum why should we close this PR? We can merge it as soon as all tests pass. Currently, inspect is unhappy (see here: https://9666-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.SeTzLMh/hpx_inspect_report.html). |
|
Okay sir. So how can I rectify that so that it May pass all test cases.
|
|
Hello @hkaiser In the details given in this report . It is giving error for "Endline whitespace" . And I have given those white spaces as to segregate them and all other counters are also added in the same way . So, how Can I rectify that error . Do I omit all white spaces and then check for the report or I may till the present state get accepted . |
|
@victor-ludorum the empty lines are ok, they just contain some (at least one) space characters. Remove those and all will be fine. |
|
Okay @hkaiser sir!! I will do it and then examine . Thanks for review!! |
References #2455
Proposed Changes
This PR has added one new arithmetic performance counter which is
count. This mainly returns the count of values present in the accumulator containing values of the underlying counters.