Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix returns when setting config entries #3223

Merged
merged 1 commit into from Mar 10, 2018
Merged

Fix returns when setting config entries #3223

merged 1 commit into from Mar 10, 2018

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Mar 9, 2018

Fixes this.

Proposed Changes

  • Don't set config entries twice if both resource partitioner and runtime are valid.

@hkaiser hkaiser added this to the 1.1.0 milestone Mar 9, 2018
hkaiser
hkaiser approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The original PR got merged too fast, this will fix the missing return statements.

@hkaiser hkaiser merged commit 737f04b into master Mar 10, 2018
@hkaiser hkaiser deleted the msimberg-patch-2 branch March 10, 2018 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: resource_partitioner type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msimberg @hkaiser