Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a coroutines wrapper for Boost.Context #354

Closed
brycelelbach opened this issue Jul 10, 2012 · 2 comments
Closed

Create a coroutines wrapper for Boost.Context #354

brycelelbach opened this issue Jul 10, 2012 · 2 comments

Comments

@brycelelbach
Copy link
Member

[reported by hkaiser] [Trac time Mon Mar 5 16:32:00 2012] Now as Boost.Context is officially accepted into Boost it is time to create a wrapper for it to be integrated with our coroutines class

@brycelelbach
Copy link
Member Author

[comment by blelbach] [Trac time Mon Mar 5 17:28:47 2012] I have serious objections to this due to flaws in the design of Boost.Context. The stack protector routines are poorly written and screw with THP on Linux, occasionally locking out 2G pages as guard pages. The assembly (for the context switch) is slower. I've tested fine-grained threading with both libraries; Boost.Context craps out very early. I do not believe it can support our threading needs.

@brycelelbach
Copy link
Member Author

[comment by hkaiser] [Trac time Mon Mar 5 19:02:02 2012] Replying to [comment:1 blelbach]:

I have serious objections to this due to flaws in the design of Boost.Context. The stack protector routines are poorly written and screw with THP on Linux, occasionally locking out 2G pages as guard pages. The assembly (for the context switch) is slower. I've tested fine-grained threading with both libraries; Boost.Context craps out very early. I do not believe it can support our threading needs.

Let's not be guided by FUD here. It's a welcome thing to get rid of some maintenance burden. Additionally Boost.Context gives us a much broader set of platforms it is available for.

@ghost ghost assigned hkaiser Sep 2, 2012
@hkaiser hkaiser closed this as completed in e575073 Sep 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants