Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform syntax for enums should be implemented #55

Closed
brycelelbach opened this issue Jul 10, 2012 · 2 comments
Closed

Uniform syntax for enums should be implemented #55

brycelelbach opened this issue Jul 10, 2012 · 2 comments

Comments

@brycelelbach
Copy link
Member

[reported by blelbach] [Trac time Wed Aug 10 15:30:33 2011] Currently, some of our older enums (such as the one for thread state, and error
codes) use a different syntax than our newer enums. Our newer enums always
prefix the enum name, e.g.

    enum foo {
        foo_bar,
        foo_buzz
    };

Our older enums generally take the form of:

    enum foo_enum {
        bar,
        buzz,
    };

We should pick a style, bite the bullet and update all the enums to that style.

@hkaiser
Copy link
Member

hkaiser commented Jul 25, 2013

This is a major breaking change, its too late in the release cycle to fix this

@hkaiser hkaiser modified the milestones: 0.9.9, 0.9.8 Mar 15, 2014
@hkaiser hkaiser modified the milestones: 1.0.0, 0.9.9 Sep 13, 2014
@hkaiser hkaiser modified the milestones: 0.9.12, 1.0.0 Apr 18, 2016
@hkaiser
Copy link
Member

hkaiser commented Apr 18, 2016

I think this can be closed now as the Boost scoped enum emulation has been replaced by C++11 strongly typed enums (see #2050).

@hkaiser hkaiser closed this as completed Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants