Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change namespaces of Public API #6000

Open
17 of 19 tasks
dimitraka opened this issue Aug 31, 2022 · 2 comments
Open
17 of 19 tasks

Change namespaces of Public API #6000

dimitraka opened this issue Aug 31, 2022 · 2 comments
Labels
type: compatibility issue type: enhancement type: feature request

Comments

@dimitraka
Copy link
Contributor

dimitraka commented Aug 31, 2022 •
edited

This is a list of the names that need to change from sub-namespaces to the hpx namespace. So far the list consists of the following:

More generic changes:

  • Remove our steady_time_point and steady_duration implementations as we have removed support for boost::chrono
@hkaiser hkaiser mentioned this issue Oct 19, 2022
Merged
bors bot pushed a commit that referenced this issue Oct 20, 2022
@hkaiser
Merge #6048
018de71 
6048: Deprecated hpx::util::invoke in favor of hpx::invoke r=hkaiser a=hkaiser

- same for hpx::util::invoke_r

Working towards resolving #6000

`@dimitraka` 

Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
@dimitraka dimitraka mentioned this issue Oct 26, 2022
Merged
bors bot pushed a commit that referenced this issue Nov 6, 2022
@dimitraka @hkaiser @kordejong
Merge #6052 #6055
5bd2b60 
6052: Deprecated hpx::util::invoke_fused in favor of hpx::invoke_fused r=hkaiser a=dimitraka

Deprecated:
-  `hpx::util::invoke_fused` in favor of `hpx::invoke_fused`
-  `hpx::util::invoke_fused_r` in favor of `hpx::invoke_fused_r`

Working towards resolving #6000

6055: Patches needed to be able to build HPX 1.8.1 on various platforms r=hkaiser a=kordejong

This PR contains a subset of patches I use to be able to build HPX-1.8.1 on all platforms I use.
Not all patches I use are needed anymore with the current state of the master branch. I left those out.

I did not keep track of which platform (OS, compiler) required which patch, unfortunately. Will do that in future cases.

The second patch, in `parcelset_base_fwd.hpp` is weird, but required in some case(s). IIRC, the `locality` class is already annotated with export somewhere else and the compiler didn't like the second occurrence. I could be wrong.

Co-authored-by: kadimitra <kadimitra@ece.auth.gr>
Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
Co-authored-by: Kor de Jong <k.dejong1@uu.nl>
@dimitraka dimitraka mentioned this issue Nov 6, 2022
Merged
bors bot pushed a commit that referenced this issue Nov 11, 2022
@dimitraka @hkaiser
Merge #6067 #6068
1fe0e16 
6067: Deprecated hpx::util::mem_fn in favor of hpx::mem_fn r=hkaiser a=dimitraka

Deprecated `hpx::util::mem_fn` in favor of `hpx::mem_fn`

Working towards resolving #6000

6068: Prevent using task and non_task as a CPO r=hkaiser a=hkaiser

This prevents using constructs like `task(par)` while still allowing writing `par(task)` (and similar).

Co-authored-by: kadimitra <kadimitra@ece.auth.gr>
Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
@vivekd01
Copy link

vivekd01 commented Jul 1, 2023

Suggested changes for the each name.
--> hpx::is_bind_expression
--> hpx::is_placeholder
--> hpx::bind_back
--> hpx::mem_fn (already deprecated)
--> hpx::invoke, hpx::invoke_r (already deprecated)
--> hpx::invoke_fused (already deprecated)
--> No need to change
--> No need to change
--> No need to change
--> No need to change
--> Leave as the last step
--> No need to change
--> hpx::unlock_guard (already deprecated)
--> hpx::experimental::reduce_by_key (already deprecated)
--> hpx::experimental::sort_by_key (already deprecated)
--> hpx::experimental::task_block (already deprecated)
--> No need to change
--> hpx::experimental::task_group

@dimitraka
Copy link
Contributor Author

Went through the list again, looks like we are only left with 2 points, the steady* and the execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: compatibility issue type: enhancement type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hkaiser @dimitraka @vivekd01