Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External build breaks if library path has spaces #672

Closed
hkaiser opened this issue Jan 21, 2013 · 1 comment
Closed

External build breaks if library path has spaces #672

hkaiser opened this issue Jan 21, 2013 · 1 comment

Comments

@hkaiser
Copy link
Member

hkaiser commented Jan 21, 2013

Any external build (which is based on FindHPX.cmake) will fail if the original HPX build depends on library or include paths containing a space. For instance, on windows, if HPX was built with ITT support enabled (which adds the Intel tools to the include and library paths), FindHPX.cmake will look like:

set(HPX_LIBRARY_DIR  
    D:/Devel/hpx/build/Debug.vc10/\$(Configuration)/lib/hpx
    D:/Devel/hpx/build/Debug.vc10/Debug/lib/hpx 
    D:/Devel/boost/stage64/lib 
    D:/Devel/hwloc-1.6.1rc1/lib 
    C:/Program\ Files\ (x86)/Intel/Inspector\ XE\ 2013/lib64
        CACHE STRING "HPX library directories")

If this FindHPX.cmake is used with an external project, the cmake cache of this project will look like:

HPX_LIBRARY_DIR:STRING=\
    D:/Devel/hpx/build/Debug.vc10/$(Configuration)/lib/hpx;\
    D:/Devel/hpx/build/Debug.vc10/Debug/lib/hpx;\
    D:/Devel/boost/stage64/lib;\
    D:/Devel/hwloc-1.6.1rc1/lib;\
    C:/Program Files ;(;x86;);/Intel/Inspector XE 2013/lib64

breaking the build.
The solution is to surround the paths in the FindHPX.cmake file with quotes:

set(HPX_LIBRARY_DIR  
    "D:/Devel/hpx/build/Debug.vc10/\$(Configuration)/lib/hpx"
    "D:/Devel/hpx/build/Debug.vc10/Debug/lib/hpx"
    "D:/Devel/boost/stage64/lib"
    "D:/Devel/hwloc-1.6.1rc1/lib"
    "C:/Program\ Files\ (x86)/Intel/Inspector\ XE\ 2013/lib64"
        CACHE STRING "HPX library directories")
@ghost ghost assigned brycelelbach Jan 21, 2013
@hkaiser
Copy link
Member Author

hkaiser commented Jan 21, 2013

As it seems it's not the space which is problematic, but the parentheses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants