Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads stolen performance counter total is incorrect #734

Closed
pagrubel opened this issue Mar 4, 2013 · 7 comments
Closed

Threads stolen performance counter total is incorrect #734

pagrubel opened this issue Mar 4, 2013 · 7 comments

Comments

@pagrubel
Copy link
Member

pagrubel commented Mar 4, 2013

 ~/hpx/hpx_build0301/bin/hpx_homogeneous_timed_task_spawn_nostop -t2 --delay 5 \
    --hpx:print-counter=/threads{locality#0/total}/count/stolen \
    --hpx:print-counter=/threads{locality#0/worker-thread#*}/count/stolen \
    --hpx:print-counter-interval 500
/threads{locality#0/total}/count/stolen,1,0.011734,[s],5
/threads{locality#0/worker-thread#0}/count/stolen,1,0.011747,[s],29
/threads{locality#0/worker-thread#1}/count/stolen,1,0.011800,[s],29
/threads{locality#0/total}/count/stolen,2,0.512029,[s],396
/threads{locality#0/worker-thread#0}/count/stolen,2,0.512030,[s],31873
/threads{locality#0/worker-thread#1}/count/stolen,2,0.512045,[s],31873
/threads{locality#0/total}/count/stolen,3,1.012201,[s],396
/threads{locality#0/worker-thread#0}/count/stolen,3,1.012273,[s],81405
/threads{locality#0/worker-thread#1}/count/stolen,3,1.012217,[s],81405
/threads{locality#0/total}/count/stolen,4,1.512453,[s],396
/threads{locality#0/worker-thread#0}/count/stolen,4,1.512405,[s],131307
/threads{locality#0/worker-thread#1}/count/stolen,4,1.512469,[s],131307
/threads{locality#0/total}/count/stolen,5,1.743491,[s],396
/threads{locality#0/worker-thread#0}/count/stolen,5,1.743504,[s],155301
/threads{locality#0/worker-thread#1}/count/stolen,5,1.743557,[s],155301
OS-threads,Tasks,Delay (micro-seconds),Total Walltime (seconds),Walltime per Task (seconds)
2,                    500000,               5,                       1.73151, 3.46303e-06
/threads{locality#0/total}/count/stolen,6,1.745433,[s],396
/threads{locality#0/worker-thread#0}/count/stolen,6,1.745379,[s],155308
/threads{locality#0/worker-thread#1}/count/stolen,6,1.745445,[s],155308

this demonstrates that there is a problem...

@ghost ghost assigned hkaiser Mar 4, 2013
@hkaiser
Copy link
Member

hkaiser commented Mar 4, 2013

This has been fixed by c7549a7:

hpx_homogeneous_timed_task_spawn --hpx:print-counter=/threads/count/stolen \
    --hpx:print-counter-interval=1000
/threads{locality#0/total}/count/stolen,1,0.287514,[s],5
/threads{locality#0/total}/count/stolen,2,2.565270,[s],108
/threads{locality#0/total}/count/stolen,3,3.578345,[s],205
/threads{locality#0/total}/count/stolen,4,4.588288,[s],205
/threads{locality#0/total}/count/stolen,5,5.597670,[s],205
/threads{locality#0/total}/count/stolen,6,6.606440,[s],205
/threads{locality#0/total}/count/stolen,7,7.614388,[s],205
/threads{locality#0/total}/count/stolen,8,8.623436,[s],205
/threads{locality#0/total}/count/stolen,9,9.635428,[s],205
/threads{locality#0/total}/count/stolen,10,10.642522,[s],205
/threads{locality#0/total}/count/stolen,11,11.654222,[s],205
/threads{locality#0/total}/count/stolen,12,12.663814,[s],205
/threads{locality#0/total}/count/stolen,13,13.673877,[s],205
/threads{locality#0/total}/count/stolen,14,14.685073,[s],205
/threads{locality#0/total}/count/stolen,15,15.693674,[s],205
/threads{locality#0/total}/count/stolen,16,16.703363,[s],205
/threads{locality#0/total}/count/stolen,17,17.716442,[s],205
/threads{locality#0/total}/count/stolen,18,18.726493,[s],205
/threads{locality#0/total}/count/stolen,19,19.740151,[s],205
/threads{locality#0/total}/count/stolen,20,20.749910,[s],205
/threads{locality#0/total}/count/stolen,21,21.757914,[s],205
/threads{locality#0/total}/count/stolen,22,22.766897,[s],205
/threads{locality#0/total}/count/stolen,23,23.777401,[s],205
/threads{locality#0/total}/count/stolen,24,24.788152,[s],205
/threads{locality#0/total}/count/stolen,25,25.801081,[s],205
/threads{locality#0/total}/count/stolen,26,26.812328,[s],205
/threads{locality#0/total}/count/stolen,27,27.820150,[s],205
/threads{locality#0/total}/count/stolen,28,28.829212,[s],205
/threads{locality#0/total}/count/stolen,29,29.837241,[s],205
/threads{locality#0/total}/count/stolen,30,30.846929,[s],205
OS-threads,Tasks,Delay (micro-seconds),Total Walltime (seconds),Walltime per Task (seconds)
1,                    500000,               0,                       30.5972, 6.11943e-005
/threads{locality#0/total}/count/stolen,31,30.912507,[s],205

@hkaiser hkaiser closed this as completed Mar 4, 2013
@pagrubel
Copy link
Member Author

pagrubel commented Mar 4, 2013

Now individual thread counts fail

~/hpx/hpx_build0301/bin/hpx_homogeneous_timed_task_spawn -t2
--delay 5 --hpx:print-counter=/threads{locality#0/worker-thread#0}/count/stolen --hpx:print-counter-interval 500
Segmentation fault

@pagrubel pagrubel reopened this Mar 4, 2013
@hkaiser
Copy link
Member

hkaiser commented Mar 5, 2013

Ok, I thought I could get away with having a single global counter for the whole locality. Darn. Seems I need to implement counters for each thread.

@hkaiser hkaiser closed this as completed in 09cec14 Mar 5, 2013
@pagrubel
Copy link
Member Author

pagrubel commented Mar 5, 2013

bin/hpx_homogeneous_timed_task_spawn -t2 --delay 5 --hpx:print-counter=/threads{locality#0/total}/count/stolen --hpx:print-counter=/threads{locality#0/worker-thread#*}/count/stolen
Segmentation fault

@pagrubel pagrubel reopened this Mar 5, 2013
@pagrubel
Copy link
Member Author

pagrubel commented Mar 5, 2013

Used the original command and got segfault

@hkaiser
Copy link
Member

hkaiser commented Mar 5, 2013

Hmmm, works for me (tm)

@pagrubel
Copy link
Member Author

pagrubel commented Mar 5, 2013

mea culpa! It does work! Thanks

@pagrubel pagrubel closed this as completed Mar 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants