Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block-matrix code as regression test #873

Merged
merged 10 commits into from Sep 25, 2013
Merged

Conversation

eschnett
Copy link
Contributor

I added a new regression test based on my block-matrix code.

@ghost ghost assigned hkaiser Sep 24, 2013
@hkaiser
Copy link
Member

hkaiser commented Sep 24, 2013

Eric, we would be happy to add your test if you please:

  • add license and copyright to all files
  • let main() return hpx::util::report_errors(); to report any detected problems back to the testing environment
  • guard all gcc specifics appropriately (for instance __building_unreachable() and #include <unistd.h>), remember, HPX is meant to be built using gcc, icc, clang, and msvc.
  • having HPX_HAVE_CXX11 is not the right way to protect this test from being build on non-c++11 platforms, please use more specific constants like CXX_HAVE_CXX11_RVALUE_REFERENCES, etc. it could also be that we don't even have an appropriate test available for some of the features you use (for instance std::initializer) - please see hpx/CMakeLists.txt, starting at line around 1023

@eschnett
Copy link
Contributor Author

Will do.

By the way, the HPX_HAVE_CXX11 is from tests/regressions/actions.

@eschnett
Copy link
Contributor Author

Done.

hkaiser added a commit that referenced this pull request Sep 25, 2013
Add block-matrix code as regression test
@hkaiser hkaiser merged commit d5a6b01 into STEllAR-GROUP:master Sep 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants