Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct grammar; simplify boolean expressions #919

Merged
merged 7 commits into from Oct 4, 2013

Conversation

eschnett
Copy link
Contributor

@eschnett eschnett commented Oct 4, 2013

No description provided.

@hkaiser
Copy link
Member

hkaiser commented Oct 4, 2013

I'll be happy to merge this (thanks for your work!) However I'd ask to leave the Boolean expressions in place as those otherwise generate warning in MSVC.

@eschnett
Copy link
Contributor Author

eschnett commented Oct 4, 2013

Would an explicit cast to bool or a comparison to zero help with that warning?

@K-ballo
Copy link
Member

K-ballo commented Oct 4, 2013

Please don't add an explicit cast to bool. For the count(...) ? true : false cases, count(...) != 0 would work and be more explicit about what they are doing. The mode != ... cases should not be generating warnings.

@eschnett
Copy link
Contributor Author

eschnett commented Oct 4, 2013

I am now using (...) != 0 instead of an implicit cast to bool.

hkaiser added a commit that referenced this pull request Oct 4, 2013
Correct grammar; simplify boolean expressions
@hkaiser hkaiser merged commit dec7386 into STEllAR-GROUP:master Oct 4, 2013
@hkaiser
Copy link
Member

hkaiser commented Oct 4, 2013

Thanks!

@ghost ghost assigned hkaiser Oct 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants