Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression_dataflow_791 needs to be brought in line with HPX standards #925

Closed
brycelelbach opened this issue Oct 5, 2013 · 4 comments
Closed
Assignees
Labels
category: tests difficulty: easy Good issues for starting out with HPX development tag: wontfix type: enhancement
Milestone

Comments

@brycelelbach
Copy link
Member

This test has the following issues:

  • Uses atoi/argc/argv for command line processing instead of utilizing boost::program_options.
  • Uses printf instead of C++ iostreams (actually, since it's a test, it shouldn't really do any output
@ghost ghost assigned brycelelbach Oct 5, 2013
@hkaiser
Copy link
Member

hkaiser commented Oct 5, 2013

Why is that an requirement? That is a concrete user program somebody contributed as it was helping to fix a bug. I tend to leave it as it is.

@brycelelbach
Copy link
Member Author

Programs should use program_options for usability. boost::program_options ensures that we have --help, etc.

I think we can all agree on the printf issue.

@sithhell
Copy link
Member

Is this still a problem?

@hkaiser hkaiser modified the milestones: 0.9.9, 0.9.8 Mar 15, 2014
@sithhell
Copy link
Member

Closing this as "won't fix" due to missing input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tests difficulty: easy Good issues for starting out with HPX development tag: wontfix type: enhancement
Projects
None yet
Development

No branches or pull requests

3 participants