Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird "5Hz2" ODR constant in several drivers #162

Closed
arbrauns opened this issue Mar 11, 2024 · 2 comments
Closed

Weird "5Hz2" ODR constant in several drivers #162

arbrauns opened this issue Mar 11, 2024 · 2 comments
Assignees
@avisconti
Labels
bug Something isn't working

Comments

@arbrauns
Copy link

Device part numbers

$ rg --files-with-matches odr_5hz2 | cut -d/ -f1 | sort -u
ais328dq_STdC
ais3624dq_STdC
iis328dq_STdC

Type of bug

driver

Describe the bug

Several drivers have a 5Hz2 output data rate (ODR) constant with a value that represents 2Hz according to the datasheet. Presumably this is a typo that has been blindly copy-pasted ever since.
@arbrauns arbrauns added the bug Something isn't working label Mar 11, 2024
@avisconti avisconti self-assigned this May 14, 2024
@avisconti
Copy link
Contributor

Of course it is 2Hz. Thanks for noticing it. I'll apply changes to all impacted drivers

avisconti added a commit to avisconti/STMems_Standard_C_drivers that referenced this issue May 14, 2024
@avisconti
Update drivers ais328dq/ais3624dq/iis328dq
e5715ca 
  - ais328dq  v2.0.1
  - ais3624dq v2.0.1
  - iis328dq  v2.0.1

Fixes STMicroelectronics#162

Signed-off-by: Armando Visconti <armando.visconti@st.com>
@avisconti
Copy link
Contributor

Closed by e5715ca

@avisconti avisconti reopened this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avisconti avisconti

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avisconti @arbrauns