Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper requires #73

Open
cbosdo opened this issue Feb 5, 2021 · 0 comments
Open

Add proper requires #73

cbosdo opened this issue Feb 5, 2021 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@cbosdo
Copy link
Contributor

cbosdo commented Feb 5, 2021

When adding custom states to configure the cluster after its creation, the user needs to add requires in his states. However these may break the linear order of the formula.

In order to make the formula more robust a few more requires would be needed. For instance in cluster/create.sls something like this would be needed on the bootstrap-the-cluster state:

     {% if cluster.watchdog is defined %}
     {% if cluster.watchdog.device is defined %}
     - require:
       - kmod: {{ cluster.watchdog.module }}
     {% endif %}
     {% endif %}

This example is one I encountered, but is surely not the only one.

@arbulu89 arbulu89 added bug Something isn't working enhancement New feature or request labels Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants