Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a DefinitelyTyped type definition for sfcc-ci #312

Open
kshehadeh opened this issue May 25, 2022 · 1 comment
Open

Created a DefinitelyTyped type definition for sfcc-ci #312

kshehadeh opened this issue May 25, 2022 · 1 comment

Comments

@kshehadeh
Copy link

Checking in here to see if there is anyone willing to take a look at DefinitelyTyped/DefinitelyTyped#60517 as a simplistic typescript definition file for sfcc-ci. Also wondering, if it's acceptable, whether it would make sense to mention its existence in the sfcc-ci README.

@clavery
Copy link
Contributor

clavery commented Jul 12, 2022

@kshehadeh It might make sense if you contributed them directly to this repo via PR and added to package.json "types" property. That's the preferred method for adding types to a project anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants