Incorrect ordering of promotion #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/incorrect_ordering
branch
from
7c31f5c
to
fa491f4
Compare
|
@ChrisRackauckas the test failure is real https://github.com/SciML/DiffEqBase.jl/actions/runs/9069483730/job/24919132493#step:6:1967. We need to figure out how to do the conversion in a device agnostic way but |
|
oh oops. Use Adapt? |
|
does Adapt natively work with RAT? I don't see any code there for that. We should probably overload |
|
that would be good to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
pis not extracted before, then it tries to promoteu0to the tracked type.