Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnsembleSummary fails for semi-unstable EnsembleProblem #533

Open
metanoid opened this issue Jun 13, 2020 · 2 comments
Open

EnsembleSummary fails for semi-unstable EnsembleProblem #533

metanoid opened this issue Jun 13, 2020 · 2 comments

Comments

@metanoid
Copy link

I have an EnsembleSolution sol for which the retcodes are a mix of :Success and :MaxIters.

EnsembleSummary(sol) fails with error:
ERROR: Solution interpolation cannot extrapolate past the final timepoint. Either solve on a longer timespan or use the local extrapolation from the integrator interface.

I think this is because not all trajectories have the same length t.

I would propose that instead of failing, the EnsembleSummary should provide the mean and quantiles up until the last shared timepoint across the EnsembleSolution, with a warning that not all timesteps have values.

@ChrisRackauckas
Copy link
Member

yeah this is a tough one. I think it's best to just throw a better error if the t's don't line up, because then what does it even mean to take the mean and variance? You cannot always rely on the interpolation (unless dense=true), so I think the safest behavior is to just throw an error telling the user they should make sure the saves are the same across the different trajectories (i.e. use saveat) if you want a summary. Otherwise I'm not sure how to calculate the summary.

@metanoid
Copy link
Author

metanoid commented Jun 13, 2020

I guess, yeah. Just to clarify, this issue can still happen, even if you are using saveat = 0.1, because there's no guarantee that there are an equal number of saved points in each trajectory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants