Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] checkver.ps1 only updates version if $version is used in autoupdate #5888

Closed
goyalyashpal opened this issue Apr 12, 2024 · 5 comments

Comments

@goyalyashpal
Copy link

goyalyashpal commented Apr 12, 2024

Feature Request

Is your feature request related to a problem? Please describe.

the scoop/bin/checkver.ps1 does not update "version": in the manifest file, if $version is not used in "autoupdate":

Describe the solution you'd like

the version is updated as per specified in checkver specification

Describe alternatives you've considered

example manifest:

{
    "$schema": "https://raw.github.com/ScoopInstaller/Scoop/master/schema.json",
    ...
    "checkver": {
        "url": "https://api.github.com/repos/eclipse-theia/theia/releases/latest",
        "jsonpath": "$.tag_name",
        "regex": "v([\\d.]+)"
    },
    "version": "1.48.2",
    "architecture": {
        "64bit": {
            "url": "https://www.eclipse.org/downloads/download.php?file=/theia/ide/latest/windows/TheiaIDESetup.exe&r=1",
            "hash": "e4481f5a6a5a1a5551c76e321e12522c300405b75dcb1d6fe0815680214d84a1"
        }
    }
}

versions

$ scoop --version | head -n2
Current Scoop version:
v0.3.1 - Released at 2022-11-15
@goyalyashpal goyalyashpal changed the title [Feature] checkver.ps1 only updates version if $version is used in architecture [Feature] checkver.ps1 only updates version if $version is used in autoupdate Apr 12, 2024
@WenSimEHRP
Copy link

WenSimEHRP commented May 11, 2024

I think you should use checkver.ps1 -u, with the extra -u argument
Hold on I misread something

@niheaven
Copy link
Member

@goyalyashpal
Copy link
Author

goyalyashpal commented May 13, 2024

hey @niheaven ! are you sure that extras/sysinternals is related to this? lack of any context is making me think u have replied to a wrong issue 😄

@niheaven
Copy link
Member

Isn't it? Wow, sysinternals manifest's autoupdate url is a fixed one, and checkver will check version update and then update file hash.

@goyalyashpal
Copy link
Author

goyalyashpal commented May 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants