Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features Generation BugFixes #34

Open
sykesdev opened this issue May 29, 2020 · 1 comment
Open

Features Generation BugFixes #34

sykesdev opened this issue May 29, 2020 · 1 comment
Assignees
Labels

Comments

@sykesdev
Copy link

Please see attached patch that fixes a bunch of bugs around feature generation in mflow.

It has the following...

  1. Fix for this issue...
    features.py get_text_features pandas 1x support #33
  2. train mode now correctly ignores the --pdate argument rather
    than falling over.
  3. Arrays of NaN in feature generation were being dropped
    rather than added as a column of sentinels.
  4. Multi feature generation was
    failing due to feature name count not matching feature count, improved the
    asserts around this and fixed the feature names.
  5. Disabled scipy signal-to-noise ratio as this seems to be long-since deprecated. (my understanding is that the scipy version currently in use would fail for this feature).

mflow_bugfixes.txt

@mrconway
Copy link
Collaborator

These issues are next to be fixed. Thank you.

@mrconway mrconway self-assigned this Aug 25, 2020
@mrconway mrconway added the bug label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants