Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trading System phigh/plow etc #37

Open
sykesdev opened this issue Jun 12, 2020 · 2 comments
Open

Trading System phigh/plow etc #37

sykesdev opened this issue Jun 12, 2020 · 2 comments
Assignees

Comments

@sykesdev
Copy link

Hi,

Looking into the Trading System in a bit more detail, unless I'm missing something I don't think this can really work as it is at present.

Using the phigh/plow feature you run into the problem that predictions are loaded from the training run which are a consolidated list of predictions for the entire group. The system then tries to join these predictions with the price data for a single stock symbol which leads to a mismatch.

It seems that it would be better if the Trading System made its own predictions using a pre-trained model for each of the stock symbols that it iterates through. I can't see any obvious way to join the predictions back with the stock symbols, running a separate prediction would avoid this problem and mean that the Trading System could be run on new test data without running the whole training cycle.

I'm thinking of looking into this, but before I leap in, it would be good to know what the consensus is on this...?

@ConsultingSecurty
Copy link

is any update on this?

@mrconway
Copy link
Collaborator

mrconway commented Aug 9, 2020

Yes, you are correct that the model trains on a group of stocks, according to the list of stocks in your market.yml file. This trained model does not apply to just a single stock, but the entire group as well when making predictions. If you just need to train for a single instrument, then you would just have a single stock in the market configuration file. For example, I do this with cryptocurrency data where BTC is the only symbol, thus the probabilities apply only to BTC.

But I do see your point. Currently, if you have a group for training, then we do not train individually on each component and then apply each independent model for prediction. This is an extremely important point for aggregated models in general. For example, if I develop a neural network tuner for one car, can I apply that model to another car? Probably not. But then you have to consider that stock behavior changes over time and consequently you have two options. Is it better to retrain each single-component model on a periodic basis, or do you have a general-purpose model that holds up historically across instruments? I don't know if many people have the answers for this.

Thank you for your thoughts, and further discussion is welcome!

@mrconway mrconway self-assigned this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants